Add more permission checks

[spacedmonkey]

Summary

When testing the editor a subscriber, I that neither the publish story button wasn't disabled. Also none of the current status were showing.

In this PR,

• Add a check on the publish button.
• Remove REST API call to status API as this data is not longer used.
• Allow user that can not publish to select draft.

Relevant Technical Choices

• The removal of the call to the status api, is needed but seemed like a good idea.

To-do

User-facing changes

Current

After this PR

Testing Instructions

• Login as contributor
• try to publish story.

---

See #1390

[github-actions]

Size Change: -61 B (0%)

Total Size: 872 kB

Filename	Size	Change
assets/js/edit-story.js	406 kB	-96 B (0%)
assets/js/stories-dashboard.js	460 kB	+35 B (0%)

ℹ️ View Unchanged

Filename	Size	Change
assets/css/edit-story.css	3.04 kB	0 B
assets/css/stories-dashboard.css	3.04 kB	0 B

_{compressed-size-action}

[codecov]

Codecov Report

Merging #1825 into master will increase coverage by 0.17%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1825      +/-   ##
============================================
+ Coverage     63.79%   63.96%   +0.17%     
  Complexity      235      235              
============================================
  Files           587      588       +1     
  Lines          9572     9602      +30     
============================================
+ Hits           6106     6142      +36     
+ Misses         3466     3460       -6     

Impacted Files	Coverage Δ	Complexity Δ
assets/src/edit-story/app/api/apiProvider.js	2.27% <ø> (+0.14%)	0.00 <0.00> (ø)
...it-story/components/inspector/inspectorProvider.js	11.76% <ø> (+2.87%)	0.00 <0.00> (ø)
assets/src/edit-story/components/header/buttons.js	87.87% <100.00%> (+0.18%)	0.00 <0.00> (ø)
...edit-story/components/inspector/document/status.js	78.12% <100.00%> (+1.45%)	0.00 <0.00> (ø)
includes/Story_Post_Type.php	59.05% <100.00%> (-0.15%)	72.00 <0.00> (ø)
...ts/src/dashboard/app/views/shared/storyListView.js	20.00% <0.00%> (-1.22%)	0.00% <0.00%> (ø%)
assets/src/dashboard/constants/index.js	100.00% <0.00%> (ø)	0.00% <0.00%> (ø%)
assets/src/dashboard/components/table/index.js	40.00% <0.00%> (ø)	0.00% <0.00%> (ø%)
assets/src/dashboard/components/viewStyleBar.js	50.00% <0.00%> (ø)	0.00% <0.00%> (ø%)
...c/dashboard/components/cardGridItem/cardPreview.js	100.00% <0.00%> (ø)	0.00% <0.00%> (ø%)
... and 1 more

[miina]

I suppose it's a UX question but should this be displayed at all without the correct permissions?

If we show anything then maybe we would need to bring in the pending status and use the "Submit for Review" option as in WordPress. This would need to be confirmed by UX though.

I'm just wondering how to make sure the "Publish" button doesn't feel broken if it's disabled due to a lack of permissions.

Maybe keep as is but follow up with UX? WDYT?

[miina]

If Draft is the only option available in radios then better to not show the radio at all. Might be a bit odd seeing a radio selection with just one option. WDYT?

[spacedmonkey]

We don't really have UX for this now. The UX might not be the best, but good enough for now.

[miina]

Sounds good to me to keep as-is for now but please follow up with @samitron7 so that she would be aware of this.

[miina]

LGTM but please follow up with Sam so that she would be aware of permissions influencing what's displayed.

[swissspidy]

A bit odd that statuses hasn't really been used in the past.

Overall looks OK, but please get final sign-off from workspace pod & make sure to track this with UX.