Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: Update template descriptions #2818

Merged
merged 3 commits into from
Jun 30, 2020

Conversation

BrittanyIRL
Copy link
Contributor

Summary

Updates the descriptions associated with templates from lorem ipsum.

Relevant Technical Choices

User-facing changes

Screen Shot 2020-06-29 at 4 00 43 PM
Screen Shot 2020-06-29 at 4 00 53 PM
Screen Shot 2020-06-29 at 4 01 13 PM
Screen Shot 2020-06-29 at 4 01 30 PM
Screen Shot 2020-06-29 at 4 01 51 PM
Screen Shot 2020-06-29 at 4 02 07 PM
Screen Shot 2020-06-29 at 4 02 32 PM
Screen Shot 2020-06-29 at 4 03 02 PM

Testing Instructions

  • Confirm that text is updated for each of the 8 templates in accordance with the above google doc

Addresses #2687

@codecov
Copy link

codecov bot commented Jun 29, 2020

Codecov Report

Merging #2818 into master will increase coverage by 1.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2818      +/-   ##
==========================================
+ Coverage   79.44%   80.49%   +1.04%     
==========================================
  Files         701      706       +5     
  Lines       11931    12008      +77     
==========================================
+ Hits         9479     9666     +187     
+ Misses       2452     2342     -110     
Flag Coverage Δ
#karmatests 59.83% <ø> (+1.23%) ⬆️
#unittests 66.23% <ø> (+0.10%) ⬆️
Impacted Files Coverage Δ
assets/src/dashboard/templates/index.js 25.00% <ø> (ø)
assets/src/edit-story/components/form/numeric.js 84.61% <0.00%> (-2.06%) ⬇️
...ory/components/library/panes/media/dropDownMenu.js 15.00% <0.00%> (-1.67%) ⬇️
...s/src/edit-story/components/panels/sizePosition.js 92.77% <0.00%> (-1.17%) ⬇️
...ts/src/edit-story/components/panels/panel/panel.js 65.90% <0.00%> (-0.76%) ⬇️
...ory/components/library/panes/media/mediaElement.js 87.87% <0.00%> (-0.19%) ⬇️
includes/Admin.php 0.00% <0.00%> (ø)
includes/Dashboard.php 68.67% <0.00%> (ø)
includes/Story_Post_Type.php 57.73% <0.00%> (ø)
assets/src/edit-story/masks/index.js 100.00% <0.00%> (ø)
... and 36 more

@github-actions
Copy link
Contributor

github-actions bot commented Jun 29, 2020

Size Change: -1.15 kB (0%)

Total Size: 872 kB

Filename Size Change
assets/js/edit-story.js 389 kB +1.5 kB (0%)
assets/js/stories-dashboard.js 466 kB -2.65 kB (0%)
ℹ️ View Unchanged
Filename Size Change
assets/css/edit-story.css 269 B 0 B
assets/css/stories-dashboard.css 305 B 0 B
assets/css/web-stories-embed-block.css 515 B 0 B
assets/js/web-stories-embed-block.js 15.7 kB 0 B

compressed-size-action

Copy link
Contributor

@mariano-formidable mariano-formidable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you copied and pasted the text from the google doc (as the typos exist there) but I found a couple typos for you to ponder over, and then it'll be good to go!

assets/src/dashboard/templates/index.js Outdated Show resolved Hide resolved
assets/src/dashboard/templates/index.js Outdated Show resolved Hide resolved
BrittanyIRL and others added 2 commits June 30, 2020 08:36
Co-authored-by: Pascal Birchler <pascalb@google.com>
Co-authored-by: Pascal Birchler <pascalb@google.com>
@BrittanyIRL BrittanyIRL linked an issue Jun 30, 2020 that may be closed by this pull request
@BrittanyIRL BrittanyIRL merged commit 080d2ef into master Jun 30, 2020
@BrittanyIRL BrittanyIRL deleted the task/2687-template-copy-updates branch June 30, 2020 16:25
@swissspidy swissspidy added the Type: Enhancement New feature or improvement of an existing feature label Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Group: Dashboard Type: Enhancement New feature or improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add description copy to templates
5 participants