-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Page Attachment as linked content #2848
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2848 +/- ##
==========================================
+ Coverage 82.78% 82.88% +0.10%
==========================================
Files 792 797 +5
Lines 13915 14055 +140
==========================================
+ Hits 11520 11650 +130
- Misses 2395 2405 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Size Change: +2.9 kB (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a single comment, but otherwise looks great. Let's get input from one more before moving to QA though, as this is quite a big feature.
@barklund @swissspidy If you have time, could you PTAL at this: 06031fd Since the real update to the CTA text happened previously only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just have a single suggestion, otherwise it looks good.
Summary
Adds the Page Attachment features as linked content.
Relevant Technical Choices
To-do
Needs UX for the general behavior in case a link ends up in an invalid position.
UX adjustments for the editor
Add "default" suffix to Learn more
Behavior when there is a linked element
Refactor code a bit
Disable links for output that are in the Page Attachment area.
Tests (Need update post-UX change)
User-facing changes
There is a new Page Attachment panel which the user can add while Page/background is selected.
The moment when the user adds a URL, the Page Attachment gets added.
Testing Instructions
I
II
III
IV
V
VI
Fixes #254