-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial setup for RTL support #351
Conversation
Still early, and not a priority, just curious to hear some thoughts about where the issues might be. How to test
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we should add rtl-tester plugin to the build to make it easier to test?
@spacedmonkey Do you mean adding RTL Tester plugin to the test environment? Or the docker setup? I was also looking into storybook support with https://www.npmjs.com/package/storybook-addon-rtl |
Both I guess. I originally meant docker setup, but testing environment makes sense too. |
Size Change: +2.27 kB (0%) Total Size: 346 kB
ℹ️ View Unchanged
|
I first had this as a to-do, but realized Gutenberg displays them the same way, so it seems to be correct 🤷♂
Yeah I think that's the same issue as in the screenshot at the top. Not sure what exactly is the culprit though. Have yet to check it out. |
So far Movable seems to be the biggest remaining issue here. |
@miina Perhaps you have some ideas on the Movable part (not urgent) |
Changes have been applied; many changes since then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looking good in my testing. The only thing I found was the dragabout elements, as noted here.
Fix Movable issues when dragging elements on a "flipped" canvas -> could be in new PR
Going to loop @miina and @dvoytenko for this one. Feels like it is a simple inversion of axioses, but I could be wrong.
Plenty of changes since initial review
Since styled components now supports this more or less out of the box, adding RTL support was rather trivial.
Fixes #55.
Fixes #317.
To-do
Before this PR:
After this PR: