Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

used publicKeyCredentialCreationOptions user.id/userHandle violates the spec #75

Closed
bodik opened this issue Jul 8, 2019 · 1 comment

Comments

@bodik
Copy link

bodik commented Jul 8, 2019

FYI publicKeyCredentialCreationOptions implementation in

user.getNickname() /* userName */, user.getEmail() /* userId */,

violates the specs at https://w3c.github.io/webauthn/#user-handle

The user handle MUST NOT contain personally identifying information about the user, such as a username or e-mail address
@cpiper
Copy link
Member

cpiper commented Aug 26, 2019

Thanks, in change a805e9e
I have modified the logic to generate random data to fill the user id field. Since there is no support for an empty allowCredentials list on the server, this should be fine at this point.

@cpiper cpiper closed this as completed Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants