Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo: NoAlertPresentException vs. NoAlertOpenException #78

Closed
seongjaelee opened this issue May 14, 2015 · 0 comments · Fixed by #79
Closed

Typo: NoAlertPresentException vs. NoAlertOpenException #78

seongjaelee opened this issue May 14, 2015 · 0 comments · Fixed by #79

Comments

@seongjaelee
Copy link

https://github.com/google/webdriver.dart/blob/master/lib/src/target_locator.dart says:

/// Throws [NoAlertPresentException] if there is not currently an alert.

However,
https://github.com/google/webdriver.dart/blob/master/lib/src/exception.dart says:

        case 27: // NoAlertOpenError
          return new NoAlertOpenException(status, message);

Java WebDriver exception name is NoAlertPresentException.
http://selenium.googlecode.com/git/docs/api/java/org/openqa/selenium/NoAlertPresentException.html

I prefer to use NoAlertPresentException, because it is also used in Java version. However, if you want to stick to use NoAlertOpenException, please fix the comment. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant