Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-Enable Tests #51

Merged
merged 3 commits into from
Mar 4, 2020
Merged

Re-Enable Tests #51

merged 3 commits into from
Mar 4, 2020

Conversation

grouma
Copy link
Member

@grouma grouma commented Mar 4, 2020

  • Add infra to install and spin up CHROMEDRIVER
  • Remove tests that no longer work since the console protocol has changed / is deprecated

Closes #24

@grouma grouma requested a review from devoncarew March 4, 2020 01:12
devoncarew
devoncarew reviewed Mar 4, 2020
View reviewed changes
Copy link
Collaborator

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, awesome! Good to get these resuscitated.

lgtm in spirit, through I expect you'll want to iterate with the CI to get things green.

@grouma grouma merged commit 41efa16 into master Mar 4, 2020
@grouma grouma deleted the tests branch March 4, 2020 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devoncarew devoncarew devoncarew left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

the tests for this package have regressed
2 participants
@grouma @devoncarew