Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: Allowing to change the output file name from wire_gen.go to other #213

Merged
merged 4 commits into from Sep 25, 2019
Merged

cmd: Allowing to change the output file name from wire_gen.go to other #213

merged 4 commits into from Sep 25, 2019

Conversation

josgilmo
Copy link
Contributor

Issue #192

@go-cloud-bot
Copy link

go-cloud-bot bot commented Sep 16, 2019

Please edit the title of this pull request with the name of the affected component, or "all", followed by a colon, followed by a short summary of the change.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Cannot accept contribution until Google CLA is signed. label Sep 16, 2019
@josgilmo
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Google CLA has been signed! and removed cla: no Cannot accept contribution until Google CLA is signed. labels Sep 16, 2019
@josgilmo josgilmo changed the title Allowing to change the output file name from wire_gen.go to other All: Allowing to change the output file name from wire_gen.go to other Sep 16, 2019
@go-cloud-bot
Copy link

go-cloud-bot bot commented Sep 16, 2019

Please edit the title of this pull request with the name of the affected component, or "all", followed by a colon, followed by a short summary of the change.

@josgilmo josgilmo changed the title All: Allowing to change the output file name from wire_gen.go to other cmd: Allowing to change the output file name from wire_gen.go to other Sep 16, 2019
internal/wire/wire.go Outdated Show resolved Hide resolved
cmd/wire/main.go Outdated Show resolved Hide resolved
cmd/wire/main.go Outdated Show resolved Hide resolved
@vangent vangent self-assigned this Sep 17, 2019
Copy link
Contributor

@vangent vangent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you see the comment on the issue about wire possibly generating multiple files?
#192 (comment)

Currently it only generates one, but that may change later, e.g., generating a file for tests.
In that scenario, a single output file name will not work well. The suggestion in the bug is
to provide an output file prefix (default empty string). Does that work for your use case?

cmd/wire/main.go Outdated Show resolved Hide resolved
@vangent vangent merged commit 55a93fa into google:master Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA has been signed!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants