Stop trusting header totalSfntSize and glyf origLength

[rsheeter]

No description provided.

[anthrotype]

This should finally fix #15 👍
I'll test later on today.

However, there is an issue when compiling with clang on OS X:

src/woff2_out.cc:34:21: error: implicit instantiation of undefined template 'std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >'
  if (offset == buf_->size()) {

I fixed the issue in my local copy by simply adding an #include <string> inside woff2_out.h.
I'm not sure it is the correct fix. Mind checking please?

Thank you!

[rsheeter]

Good catch, ty. At a glance adding the #include seems correct, will double-check and fix.

[rsheeter]

4e698b8 should fix clang (tested on OSX 10.11.3, Apple LLVM 7.0.2 / clang-700.1.81).

[anthrotype]

👍

[khaledhosny]

After a few hours of debugging, I realized that I need to switch OTS to the new API to benefit from this. Would it make sense to drop the old API to avoid such confusion?

[rsheeter]

Sorry, I should have posted an OTS issue to switch.

As this repo is public and in use we wouldn't typically remove the old API. Maybe we should at least comment it deprecated though.