Google -> GitHub Sync, 1 Feb 2017 #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=142548323
…blicSpec(). The corresponding bug was fixed in BC 1.55 or BC 1.56. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=142561682
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=142743772
- this adds more comments for bugtypes and modifications or the signatures. - fixes some ugly formatting. - adds some additional test vectors. There are no new bugs. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=144619819
This adds a few more test vectors. The test vectors are now divided between test vectors with valid BER encodings and test vectors with invalid DER encodings. The description of the test vector better describes what was modified. Also fixing issue C2SP#17 on Github: testVectors in DsaTest not using the message parameter There are no changes to the presubmit tests. Tests that can be enabled because of the Oracles security update will be added in another CL. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=144814889
Merging a test with small order into the test vectors. Fixing ASN encoding of 0 (from 0200 to 020100, i.e. length must be > 0). ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=144815129
Adding test vectors that were removed because of b/31575502. Oracle fixes this with CVE-2016-5547. Changing ASN tags with value 0x50 to 0x30 (0x50 would be something like sequence of sequence but does not exist), hence the old vectors are unlikely to cause problems. Adding more modifications of OIDs. The new vectors unpack the OIDs and change the nodes. (E.g. the OID for sha256 is the hexadecimal string "608648016503040201" which is an ASN encoding of "2.16.840.1.101.3.4.2.1". The new test vectors include invalid encoding, encodings with additional nodes, deleted nodes and nodes that are changed to large integers) ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=144846826 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=145060646
…ally and upstream. Mainly these are tests with CVEs that were announced during the Jan 17 security update by Oracle. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=145397539 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=145418516
…umentation. Minor changes to some test vectors: Some of the garbage added to the ASN encoding was itself incorrect and has been replaced. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=145650774
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=146186539
cryptosubtlety
approved these changes
Feb 1, 2017
ekasper
approved these changes
Feb 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Releasing new tests that were fixed in the Jan 17 security update by Oracle + various typo and bug fixes