Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent Pathways SIGTERMs from counting against backoffLimit #134

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Prevent Pathways SIGTERMs from counting against backoffLimit #134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions xpk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,10 +265,20 @@ class CapacityType(enum.Enum):
xpk.google.com/workload: {args.workload}
spec:
backoffLimit: 4
podFailurePolicy:
rules:
- action: Ignore # one of: Ignore, FailJob, Count
onExitCodes:
containerName: "pathways-worker"
operator: In # one of: In, NotIn
# TODO: verify this is the correct exit code
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this TODO now considering you have verified this exit code?

values: [143] # Don't count SIGTERMed workers against the backoffLimit
onPodConditions: []
completions: {system.vms_per_slice}
parallelism: {system.vms_per_slice}
template:
spec:
restartPolicy: Never
terminationGracePeriodSeconds: {args.termination_grace_period_seconds}
containers:
- args:
Expand Down
Loading