hotfix: add utf-8 parsint for emoji_support #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a major bug in yaml.v3 that makes it incapable of encoding emojis. There has been an issue and PR open to fix it for a very long time, but it has still gotten no attention. This PR adds a new hotfix that will parse the literal `\U00000000` codepoint sequences that yaml.v3 produces and outputs the unicode encoding. It can be enabled with the new `emoji_support` configuration value for the basic formatter. Unfortunately, any scalar with an emoji will come out double quoted; might be able to rectify this but it will be very nasty. Going to accept that consequence for now to unblock this breakage.
It was weird having p.write and a manual p.out append so I wrote a method for that for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #38
There is a major bug in yaml.v3 that makes it incapable of encoding
emojis. There has been an issue and PR open to fix it for a very long
time, but it has still gotten no attention. This PR adds a new hotfix
that will parse the literal
\U00000000codepoint sequences that yaml.v3produces and outputs the unicode encoding. It can be enabled with the
new
emoji_supportconfiguration value for the basic formatter.Unfortunately, any scalar with an emoji will come out double quoted;
might be able to rectify this but it will be very nasty. Going to accept
that consequence for now to unblock this breakage.
This uses a library I made on my personal account in some spare time I had. https://github.com/RageCage64/go-utf8-codepoint-converter