fix: line break format issue after refactor code #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braydonk
approved these changes
Sep 12, 2022
| if strings.TrimSpace(txt) == "" { // line break or empty space line. | ||
| buf.WriteString(padding.String()) // prepend some padding incase literal multiline strings. | ||
| buf.WriteString(lineBreakPlaceholder) | ||
| buf.WriteString(newlineStr) | ||
| continue | ||
| } | ||
| buf.WriteString(txt) | ||
| buf.WriteByte('\n') | ||
| buf.WriteString(newlineStr) |
There was a problem hiding this comment.
Ah nice catch, I missed that. I'll have to add some crlf test cases some time soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I notice my PR for retaining line breaks got refactors. However the original indentLen func got removed. It's required. Things got complicated when yaml contains literal multi-line string. If the indent is fixed 2, when it comes to multi-level indent string the format result will be wrong. So the
paddingeralways return the max padding for each line.This PR fixes the refactor regression issue and explicitly add a test case.