chore: better format defaults #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longkai
force-pushed
the
chore/better-defaults
branch
from
3982c3c
to
df8b4a4
Compare
braydonk
reviewed
Sep 12, 2022
formatters/basic/config.go
Outdated
| LineEnding: lineBreakStyle, | ||
| Indent: 2, | ||
| LineEnding: lineBreakStyle, | ||
| RetainLineBreaks: true, |
There was a problem hiding this comment.
My rule has been that if there's a feature that has to hack around a shortcoming of the yaml library, I have it turned off by default to make the most stable possible default experience (despite weird behaviours from the library).
Does the vscode extension not read from the working directory's .yamlfmt or accept options from settings.json?
There was a problem hiding this comment.
OK, it's fine. I suppose everybody needs the feature and I could make it default in vscode.
braydonk
reviewed
Sep 12, 2022
| @@ -122,7 +122,7 @@ func RunCommand( | |||
| if err != nil { | |||
| return err | |||
| } | |||
| fmt.Println(string(out)) | |||
| fmt.Print(string(out)) | |||
There was a problem hiding this comment.
That's a good idea, I didn't think of that.
There was a problem hiding this comment.
So, how about this PR only changes this line 😅
There was a problem hiding this comment.
That would be fine with me!
Each time saving the file, the format result will always insert a new line at the end, which is annoying.
longkai
force-pushed
the
chore/better-defaults
branch
from
df8b4a4
to
98a64ba
Compare
braydonk
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now I bundle the binary as a vscode extension. I use the stdin method to do the job and set the editor settings
formatOnSavetrue. Each time saving the file, the format result will always insert a new line at the end, which is annoying.So, this PR: