New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New tag; pre-commit config step #882
Comments
Related: pre-commit wants the hook file to be called
Simply renaming the two pre-commit config files should address this issue. |
Oh, that's a nice catch. We could certainly try naming it in that manner. But according to me that would not suffice, if you could please verify, by checking out |
I agree, a tag is needed, as you say, in addition to renaming. I mentioned it on this ticket because it's a "blocker" that needs to be addressed before tagging, and I didn't want to create a separate ticket since both changes are simple. |
@gwelymernans this issue isn't actually resolved. A new tag is still needed to be able to refer to this repo in external projects. I need to be able to say something like:
I can choose to use a |
To clarify @tpdownes comment, there needs to be a git tag in the repo. Here is a GitHub screenshot of some of the current tags. |
@gwelymernans can we expect/hope for a tag? |
Thank you! For those who used |
See google/yapf#882 (comment). I'm not sure if the .git hooks folder needs to be committed or not but I'll not. Useful commands: pip install pre-commit pre-commit run --all-files
A new tag should be created for pre-commit config #878 to come into effect.
Since, the usage of a GitHub repository or a hook configured repo as a pre-commit hook requires a reference version/tag to pull from the base,
Cheers
The text was updated successfully, but these errors were encountered: