Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arithmetic precedence indication #671

Merged
merged 11 commits into from
Feb 8, 2019
Merged

Arithmetic precedence indication #671

merged 11 commits into from
Feb 8, 2019

Conversation

harahu
Copy link
Contributor

@harahu harahu commented Feb 7, 2019

Add an option to remove spaces around highest priority operations
in complex arithmetic expressions. This is motivated by the PEP8
suggestion to to do this.

This is an attempt at resolving #670

@harahu
Arithmetic precedence indication
9dadcc5 
Add an option to remove spaces around highest priority operations
in complex arithmetic expressions. This is motivated by the PEP8
suggestion to to do this.
@coveralls
Copy link

coveralls commented Feb 7, 2019 •
edited

Coverage Status

Coverage increased (+0.1%) to 95.61% when pulling e2aa364 on harahu:arithmetic-precedence-indication into 9546d40 on google:master.

bwendling
bwendling reviewed Feb 7, 2019
View reviewed changes
Copy link
Member

@bwendling bwendling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update CHANGELOG.

yapf/yapflib/unwrapped_line.py Outdated Show resolved Hide resolved
yapf/yapflib/unwrapped_line.py Outdated Show resolved Hide resolved
yapf/yapflib/unwrapped_line.py Outdated Show resolved Hide resolved
yapf/yapflib/unwrapped_line.py Outdated Show resolved Hide resolved
yapf/yapflib/unwrapped_line.py Outdated Show resolved Hide resolved
@harahu
Copy link
Contributor Author

harahu commented Feb 8, 2019

Please update CHANGELOG.

Done.

bwendling
bwendling reviewed Feb 8, 2019
View reviewed changes
Copy link
Member

@bwendling bwendling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! Just a few comments. Thanks!

yapf/yapflib/unwrapped_line.py Outdated Show resolved Hide resolved
yapftests/reformatter_style_config_test.py Show resolved Hide resolved
@bwendling bwendling merged commit 0766b9f into google:master Feb 8, 2019
@harahu harahu deleted the arithmetic-precedence-indication branch February 8, 2019 21:51
@harahu harahu mentioned this pull request Feb 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwendling bwendling bwendling left review comments

@areeh areeh areeh left review comments

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@harahu @coveralls @bwendling @areeh @googlebot