Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync zerocopy and zerocopy-derive version numbers, have zerocopy depend on an exact version of zerocopy-derive #107

Closed
joshlf opened this issue Oct 27, 2022 · 0 comments · Fixed by #108
Closed

Sync zerocopy and zerocopy-derive version numbers, have zerocopy depend on an exact version of zerocopy-derive #107

joshlf opened this issue Oct 27, 2022 · 0 comments · Fixed by #108

Comments

@joshlf
Copy link
Member

joshlf commented Oct 27, 2022

This has a few advantages:

  • It helps make it clear that zerocopy-derive is just an implementation detail of zerocopy, and shouldn't be depended upon directly
  • It makes reasoning about compatibility simpler by effectively making both crates part of a single codebase. So long as the code in zerocopy is compatible with the code in zerocopy-derive in the same Git commit, then publishing them both is fine. No more need to consider compatibility between a given version of zerocopy and a range of versions of zerocopy-derive.

Note that serde does this too. Serde has a ton of experience with these sorts of issues, so all else being equal, it's a reasonable idea to do what serde does.
joshlf added a commit that referenced this issue Oct 28, 2022
@joshlf
Have zerocopy depend exactly on derive version
84fedba 
Have zerocopy depend on an exact version of zerocopy-derive. See the
note added to `INTERNAL.md` in this commit for a justification.

Closes #107
@joshlf joshlf mentioned this issue Oct 28, 2022
Merged
joshlf added a commit that referenced this issue Oct 28, 2022
@joshlf
Have zerocopy depend exactly on derive version
c28240f 
Have zerocopy depend on an exact version of zerocopy-derive. See the
note added to `INTERNAL.md` in this commit for a justification.

Closes #107
joshlf added a commit that referenced this issue Oct 28, 2022
@joshlf
Have zerocopy depend exactly on derive version
5adebb4 
Have zerocopy depend on an exact version of zerocopy-derive. See the
note added to `INTERNAL.md` in this commit for a justification.

Closes #107
joshlf added a commit that referenced this issue Oct 28, 2022
@joshlf
Have zerocopy depend exactly on derive version
0c0742f 
Have zerocopy depend on an exact version of zerocopy-derive. See the
note added to `INTERNAL.md` in this commit for a justification.

Closes #107
@joshlf joshlf mentioned this issue Aug 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Have zerocopy depend exactly on derive version google/zerocopy
1 participant
@joshlf