Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Ref constructors which zero bytes? #1134

Closed
Tracked by #671
joshlf opened this issue Apr 23, 2024 · 0 comments · Fixed by #1135
Closed
Tracked by #671

Remove Ref constructors which zero bytes? #1134

joshlf opened this issue Apr 23, 2024 · 0 comments · Fixed by #1135

Comments

@joshlf
Copy link
Member

joshlf commented Apr 23, 2024

These constructors were added to make it easy to zero the contents of a buffer before further use with the goal of avoiding data leaks (e.g. when a buffer is used repeatedly to store multiple packets). These APIs are very cumbersome to maintain, as they effectively duplicate our API surface. They are also of limited utility, since a user can very easily zero the buffer manually before or after calling the constructor.

@joshlf joshlf mentioned this issue Apr 23, 2024
51 tasks
joshlf added a commit that referenced this issue Apr 23, 2024
github-merge-queue bot pushed a commit that referenced this issue Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant