Implement FromBytes::{mut,ref}_from_with_trailing_elements
#1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jswrenn
commented
May 10, 2024
| /// trailing_dst: [()], | ||
| /// } | ||
| /// | ||
| /// let src = &[85, 85][..]; |
joshlf
requested changes
May 10, 2024
src/lib.rs
Outdated
| /// ``` | ||
| /// | ||
| /// Since an explicit `count` is provided, this method supports types with | ||
| /// zero-sided trailing slice elements. Methods such as [`ref_from`] |
There was a problem hiding this comment.
Suggested change
| /// zero-sided trailing slice elements. Methods such as [`ref_from`] | |
| /// zero-sized trailing slice elements. Methods such as [`ref_from`] |
(And elsewhere while you're at it - looks like a typo snuck in to main)
src/lib.rs
Outdated
| /// ``` | ||
| /// | ||
| /// Since an explicit `count` is provided, this method supports types with | ||
| /// zero-sided trailing slice elements. Methods such as [`mut_from`] which |
There was a problem hiding this comment.
Suggested change
| /// zero-sided trailing slice elements. Methods such as [`mut_from`] which | |
| /// zero-sized trailing slice elements. Methods such as [`mut_from`] which |
jswrenn
force-pushed
the
frombytes-with-count
branch
from
b903253
to
07d6369
Compare
Makes progress on #29
jswrenn
force-pushed
the
frombytes-with-count
branch
from
07d6369
to
b39bdc9
Compare
joshlf
approved these changes
May 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes progress on #29