Remove .forget_exclusive from Ptr::try_into_valid #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jswrenn
approved these changes
May 14, 2024
This causes methods like `TryFromBytes::try_mut_from` to fail compilation during post-monomorphization when used with types containing `UnsafeCell`s. This wasn't caught because our tests hadn't been updated to exercise this condition. This commit also updates the tests so this can't slip through in the future.
joshlf
force-pushed
the
exclusive-unsafe-cell-tests
branch
from
a03a65d
to
1c71488
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes methods like
TryFromBytes::try_mut_fromto fail compilation during post-monomorphization when used with types containingUnsafeCells. This wasn't caught because our tests hadn't been updated to exercise this condition. This commit also updates the tests so this can't slip through in the future.