Cache the dependencies #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlf
reviewed
Aug 31, 2023
Append a new line to avoid the previous cache
zoo868e
commented
Aug 31, 2023
zoo868e
commented
Aug 31, 2023
joshlf
reviewed
Sep 3, 2023
joshlf
requested changes
Sep 4, 2023
There was a problem hiding this comment.
Okay, I think this is in a good state other than a few small cleanup items. Thanks so much for your work on this, @zoo868e! Very excited to have more reliable jobs - they've been failing a lot recently and causing a lot of headache.
joshlf
requested changes
Sep 4, 2023
In this commit, we optimize the population of the global Cargo registry and cache in the CI workflow. By populating the cache before running the jobs in the matrix, we avoid redundant downloads of crates from the internet, improving overall workflow efficiency. We also include the following changes: - Removed the 'Clean build artifacts' step, as it's no longer needed after cache population. - Added comments to clarify the purpose of the 'Populate cache' step and its best-effort nature. These changes enhance the CI workflow's performance and ensure that dependencies are efficiently managed during the build process.
joshlf
requested changes
Sep 4, 2023
joshlf
approved these changes
Sep 4, 2023
joshlf
added a commit
that referenced
this pull request
Sep 4, 2023
The caching introduced in #302 fixes the issue that this override was meant to address, so it's no longer necessary.
|
Awesome, thanks so much for all your work on this, @zoo868e! At least based on how the jobs ran on this PR, I expect this is going to almost entirely fix the issue (perhaps with the exception of cases where populating the cache itself fails, which should presumably be much less common than at least one of 149 jobs failing for the same reason). |
joshlf
added a commit
that referenced
this pull request
Sep 4, 2023
The caching introduced in #302 fixes the issue that this override was meant to address, so it's no longer necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #295