Add TryFromBytes::try_from_ref, impl for bool #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlf
force-pushed
the
try-from-bytes-external-impls-not-from-bytes
branch
from
9fcfb42
to
91b03f2
Compare
Add the `TryFromBytes::try_from_ref` method, which permits conditionally converting a `&[u8]` to a `&Self`, using `is_bit_valid` for runtime validation. Implement `TryFromBytes` for `bool`. Add a framework for testing `TryFromBytes` impls. Makes progress on #5
joshlf
force-pushed
the
try-from-bytes-external-impls-not-from-bytes
branch
from
91b03f2
to
bf516d7
Compare
jswrenn
approved these changes
Nov 28, 2023
| where | ||
| Self: KnownLayout, | ||
| { | ||
| let maybe_self = Ptr::from(bytes).try_cast_into_no_leftover::<Self>()?; |
There was a problem hiding this comment.
Still pondering how we might improve this name. What a mouthful! Maybe try_cast_all_into?
There was a problem hiding this comment.
Eh, it's an internal API. I'm not too worried about it being verbose, and IMO it's more important to be clear.
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
TryFromBytes::try_from_refmethod, which permits conditionally converting a&[u8]to a&Self, usingis_bit_validfor runtime validation.Implement
TryFromBytesforbool.Add a framework for testing
TryFromBytesimpls.Makes progress on #5