Lower MSRV to 1.56 #855
Merged
Lower MSRV to 1.56 #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlf
force-pushed
the
lower-msrv-1-56
branch
from
be8fdd7
to
e1c47d5
Compare
jswrenn
requested changes
Feb 8, 2024
src/lib.rs
Outdated
| @@ -430,7 +432,7 @@ impl DstLayout { | |||
| const THEORETICAL_MAX_ALIGN: NonZeroUsize = | |||
| match NonZeroUsize::new(1 << (POINTER_WIDTH_BITS - 1)) { | |||
| Some(max_align) => max_align, | |||
| None => unreachable!(), | |||
| None => loop {}, | |||
There was a problem hiding this comment.
Can we replace these loop {}s with a macro that conditionally either panics or loops?
joshlf
force-pushed
the
lower-msrv-1-56
branch
from
e1c47d5
to
39da039
Compare
joshlf
force-pushed
the
lower-msrv-1-56
branch
4 times, most recently
from
8775f70
to
38b384a
Compare
auto-merge was automatically disabled
February 9, 2024 00:49
Pull Request is not mergeable
joshlf
force-pushed
the
lower-msrv-1-56
branch
from
38b384a
to
d2925d8
Compare
joshlf
force-pushed
the
lower-msrv-1-56
branch
from
d2925d8
to
ffbf0f7
Compare
jswrenn
previously approved these changes
Feb 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
joshlf
force-pushed
the
lower-msrv-1-56
branch
from
ffbf0f7
to
3691da1
Compare
joshlf
force-pushed
the
lower-msrv-1-56
branch
from
3691da1
to
465ec56
Compare
jswrenn
previously approved these changes
Feb 10, 2024
Makes progress on #554
joshlf
force-pushed
the
lower-msrv-1-56
branch
from
465ec56
to
62def58
Compare
jswrenn
approved these changes
Feb 10, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes progress on #554