[derive] Support IntoBytes on some generic structs #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlf
force-pushed
the
derive-as-bytes-generic-unaligned
branch
4 times, most recently
from
196982e
to
ee14390
Compare
joshlf
added a commit
that referenced
this pull request
Feb 10, 2024
In particular, support `AsBytes` on structs with generic type parameters so long as: - The type is `repr(C)` and has zero or one fields - All field types (including concrete types) implement `Unaligned` This change was backported from #862
jswrenn
requested changes
Feb 12, 2024
zerocopy-derive/src/lib.rs
Outdated
| &ast, | ||
| strct, | ||
| Trait::NoCell, | ||
| FieldBounds::All(&[Trait::NoCell]), |
There was a problem hiding this comment.
Can we add a Trait::Self? The correctness of all of these derives depends on the FieldBounds::All(&[Trait::XXX]) having the same Trait::XXX as the parameter before it.
There was a problem hiding this comment.
Trait::Self would require adding panic paths in impl_block (namely, it would be invalid to pass Trait::Self as the trt argument - the trait to be implemented), so I added a separate TraitBound enum that should have the same effect without introducing panic paths. Lmk if that looks better.
joshlf
force-pushed
the
derive-as-bytes-generic-unaligned
branch
2 times, most recently
from
fae2cab
to
3897534
Compare
In particular, support `IntoBytes` on structs with generic type parameters so long as: - The type is `repr(C)` and has zero or one fields - All field types (including concrete types) implement `Unaligned` Closes #825
joshlf
force-pushed
the
derive-as-bytes-generic-unaligned
branch
from
3897534
to
b0f097e
Compare
|
Filed this to track improving the error messages: #868 |
jswrenn
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, support
IntoByteson structs with generic type parameters so long as:repr(C)and has zero or one fieldsUnalignedCloses #825