Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Run cargo fix when rolling toolchains #943

Merged
merged 1 commit into from
Feb 23, 2024
Merged

[ci] Run cargo fix when rolling toolchains #943

merged 1 commit into from
Feb 23, 2024

Conversation

joshlf
Copy link
Member

@joshlf joshlf commented Feb 23, 2024

Closes #918

@joshlf joshlf requested a review from jswrenn February 23, 2024 17:58
@joshlf
Copy link
Member Author

joshlf commented Feb 23, 2024 •
edited

Testing this manually: https://github.com/google/zerocopy/actions/runs/8023185961

@joshlf
Copy link
Member Author

joshlf commented Feb 23, 2024

Okay, looks like the roller is successfully getting past the cargo fix step. It's failing at a later step, but that's not relevant to this PR.

@joshlf joshlf added this pull request to the merge queue Feb 23, 2024
Merged via the queue into main with commit d982b5b Feb 23, 2024
211 of 213 checks passed
@joshlf joshlf deleted the roll-cargo-fix branch February 23, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jswrenn jswrenn jswrenn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto-roller should run cargo fix
2 participants
@joshlf @jswrenn