Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Node.js v16 and node-fetch dependency #687

Closed
gajus opened this issue Oct 23, 2023 · 1 comment · Fixed by #722
Closed

Drop Node.js v16 and node-fetch dependency #687

gajus opened this issue Oct 23, 2023 · 1 comment · Fixed by #722

Comments

@gajus
Copy link

gajus commented Oct 23, 2023

node-fetch is only required because of Node.js v16.

Node.js v16 is already pass its end-of-life date.

node-fetch comes with a huge bundle size due to its dependencies.

This prevents tools like Turbowatch, that depend on zx` from broader adoption.
@gajus gajus mentioned this issue Oct 23, 2023
Open
4 tasks
@antonmedv
Copy link
Collaborator

Yeap, this is in our plan for #589

@GaelGirodon GaelGirodon mentioned this issue Jan 7, 2024
Closed
3 tasks
@antongolub antongolub mentioned this issue Feb 24, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: generate js and dts bundles antongolub/zx
2 participants
@antonmedv @gajus