-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creation of a GoogleAdsException for test purpose do not work anymore with v12 #402
Comments
I too use this method in tests to mock failures and have run into this bug when using 12.0.0 I have reverted to version 11.0.1 for the time being. // Works in 11.0.1 not 12.0.0 |
@danny-quinn i've found an alternative which is less pretty but work until its fixed private GoogleAdsException GetFakeGoogleAdsException() |
Sorry about that, PR is out for review. |
Fixed in 12.1.0. |
I was using the following line to create a fake exception for my mock:
var exception = GoogleAdsException.Create(new RpcException(Status.DefaultCancelled));
It do not work anymore.
trailer object inside the lib is empty. Its searching for the key
google.ads.googleads.v9.errors.googleadsfailure-bin
Object Lib\AdsBaseException.cs, line 98
The text was updated successfully, but these errors were encountered: