Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for client library release 2.6 #125

Merged
merged 13 commits into from
Dec 3, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 17 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,20 @@
2.6.0
=====
- Optimize for a check on section name if it is empty in the GoogleAdsConfig class.
- Add a specialized ConfigSetting class named StringConfigSetting for string
settings, so its parsing can be bypassed. Switch all string-based setting parsing to this type in
the GoogleAdsConfig class.
- Expose the Dictionary constructor in the base class at GoogleAdsConfig level.
- Improve how DEFAULT_TIMEOUT is represented in GoogleAdsConfig class.
- Eliminate the provision to use user CallSettings.
- Eliminate reflection in creating service, instead use specific autogenerated methods to create
the service settings.
- Add an explicit dependency on Google.Protobuf so we can use a newer version than what Gax.Grpc uses.
- Bump all nuget dependencies to the latest versions.
- Remove deprecated PackageLicenseUrl setting from Google.Ads.GoogleAds.csproj, and replace it with
PackageLicenseExpression setting instead.
- Update AddHotelAd.cs example to change the AdGroupAd status to be Enabled.

2.5.0
=====
- Added support for Google Ads API v2.2. See release notes:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Google.Apis.Auth" Version="1.39.0" />
<PackageReference Include="Google.Apis.Auth" Version="1.42.0" />
</ItemGroup>
<ItemGroup>
<Reference Include="System.Web" />
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<Project ToolsVersion="12.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Import Project="..\..\..\packages\Microsoft.Net.Compilers.3.2.1\build\Microsoft.Net.Compilers.props" Condition="Exists('..\..\..\packages\Microsoft.Net.Compilers.3.2.1\build\Microsoft.Net.Compilers.props')" />
<Import Project="..\..\..\packages\Microsoft.Net.Compilers.3.3.1\build\Microsoft.Net.Compilers.props" Condition="Exists('..\..\..\packages\Microsoft.Net.Compilers.3.3.1\build\Microsoft.Net.Compilers.props')" />
<Import Project="..\..\..\packages\Microsoft.CodeDom.Providers.DotNetCompilerPlatform.2.0.1\build\net45\Microsoft.CodeDom.Providers.DotNetCompilerPlatform.props" Condition="Exists('..\..\..\packages\Microsoft.CodeDom.Providers.DotNetCompilerPlatform.2.0.1\build\net45\Microsoft.CodeDom.Providers.DotNetCompilerPlatform.props')" />
<Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
<PropertyGroup>
Expand Down Expand Up @@ -50,46 +50,49 @@
<Project>{C691BD4D-683D-425B-8BC7-52F161475C7C}</Project>
<Name>Google.Ads.GoogleAds</Name>
</ProjectReference>
<Reference Condition="!Exists('..\..\..\src\Google.Ads.GoogleAds.csproj')" Include="Google.Ads.GoogleAds, Version=2.5.0.0, Culture=neutral, PublicKeyToken=52807268f2b614dc, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\Google.Ads.GoogleAds.2.5.0\lib\net452\Google.Ads.GoogleAds.dll</HintPath>
<Reference Condition="!Exists('..\..\..\src\Google.Ads.GoogleAds.csproj')" Include="Google.Ads.GoogleAds, Version=2.6.0.0, Culture=neutral, PublicKeyToken=52807268f2b614dc, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\Google.Ads.GoogleAds.2.6.0\lib\net452\Google.Ads.GoogleAds.dll</HintPath>
</Reference>
</ItemGroup>
<ItemGroup>
<Reference Include="Google.Api.CommonProtos, Version=1.7.0.0, Culture=neutral, PublicKeyToken=3ec5ea7f18953e47, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\Google.Api.CommonProtos.1.7.0\lib\net45\Google.Api.CommonProtos.dll</HintPath>
</Reference>
<Reference Include="Google.Api.Gax, Version=2.9.0.0, Culture=neutral, PublicKeyToken=3ec5ea7f18953e47, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\Google.Api.Gax.2.9.0\lib\net45\Google.Api.Gax.dll</HintPath>
<Reference Include="Google.Api.Gax, Version=2.10.0.0, Culture=neutral, PublicKeyToken=3ec5ea7f18953e47, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\Google.Api.Gax.2.10.0\lib\net45\Google.Api.Gax.dll</HintPath>
</Reference>
<Reference Include="Google.Api.Gax.Grpc, Version=2.9.0.0, Culture=neutral, PublicKeyToken=3ec5ea7f18953e47, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\Google.Api.Gax.Grpc.2.9.0\lib\net45\Google.Api.Gax.Grpc.dll</HintPath>
<Reference Include="Google.Api.Gax.Grpc, Version=2.10.0.0, Culture=neutral, PublicKeyToken=3ec5ea7f18953e47, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\Google.Api.Gax.Grpc.2.10.0\lib\net45\Google.Api.Gax.Grpc.dll</HintPath>
</Reference>
<Reference Include="Google.Apis, Version=1.41.1.0, Culture=neutral, PublicKeyToken=4b01fa6e34db77ab, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\Google.Apis.1.41.1\lib\net45\Google.Apis.dll</HintPath>
<Reference Include="Google.Apis, Version=1.42.0.0, Culture=neutral, PublicKeyToken=4b01fa6e34db77ab, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\Google.Apis.1.42.0\lib\net45\Google.Apis.dll</HintPath>
</Reference>
<Reference Include="Google.Apis.Auth, Version=1.41.1.0, Culture=neutral, PublicKeyToken=4b01fa6e34db77ab, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\Google.Apis.Auth.1.41.1\lib\net45\Google.Apis.Auth.dll</HintPath>
<Reference Include="Google.Apis.Auth, Version=1.42.0.0, Culture=neutral, PublicKeyToken=4b01fa6e34db77ab, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\Google.Apis.Auth.1.42.0\lib\net45\Google.Apis.Auth.dll</HintPath>
</Reference>
<Reference Include="Google.Apis.Auth.PlatformServices, Version=1.41.1.0, Culture=neutral, PublicKeyToken=4b01fa6e34db77ab, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\Google.Apis.Auth.1.41.1\lib\net45\Google.Apis.Auth.PlatformServices.dll</HintPath>
<Reference Include="Google.Apis.Auth.PlatformServices, Version=1.42.0.0, Culture=neutral, PublicKeyToken=4b01fa6e34db77ab, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\Google.Apis.Auth.1.42.0\lib\net45\Google.Apis.Auth.PlatformServices.dll</HintPath>
</Reference>
<Reference Include="Google.Apis.Core, Version=1.41.1.0, Culture=neutral, PublicKeyToken=4b01fa6e34db77ab, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\Google.Apis.Core.1.41.1\lib\net45\Google.Apis.Core.dll</HintPath>
<Reference Include="Google.Apis.Core, Version=1.42.0.0, Culture=neutral, PublicKeyToken=4b01fa6e34db77ab, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\Google.Apis.Core.1.42.0\lib\net45\Google.Apis.Core.dll</HintPath>
</Reference>
<Reference Include="Google.Apis.PlatformServices, Version=1.41.1.0, Culture=neutral, PublicKeyToken=4b01fa6e34db77ab, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\Google.Apis.1.41.1\lib\net45\Google.Apis.PlatformServices.dll</HintPath>
<Reference Include="Google.Apis.PlatformServices, Version=1.42.0.0, Culture=neutral, PublicKeyToken=4b01fa6e34db77ab, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\Google.Apis.1.42.0\lib\net45\Google.Apis.PlatformServices.dll</HintPath>
</Reference>
<Reference Include="Google.Protobuf, Version=3.9.1.0, Culture=neutral, PublicKeyToken=a7d26565bac4d604, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\Google.Protobuf.3.9.1\lib\net45\Google.Protobuf.dll</HintPath>
<Reference Include="Google.LongRunning, Version=1.1.0.0, Culture=neutral, PublicKeyToken=185c282632e132a0, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\Google.LongRunning.1.1.0\lib\net45\Google.LongRunning.dll</HintPath>
</Reference>
<Reference Include="Grpc.Auth, Version=2.0.0.0, Culture=neutral, PublicKeyToken=d754f35622e28bad, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\Grpc.Auth.2.23.0\lib\net45\Grpc.Auth.dll</HintPath>
<Reference Include="Google.Protobuf, Version=3.11.1.0, Culture=neutral, PublicKeyToken=a7d26565bac4d604, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\Google.Protobuf.3.11.1\lib\net45\Google.Protobuf.dll</HintPath>
</Reference>
<Reference Include="Grpc.Auth, Version=1.0.0.0, Culture=neutral, PublicKeyToken=d754f35622e28bad, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\Grpc.Auth.1.22.1\lib\net45\Grpc.Auth.dll</HintPath>
</Reference>
<Reference Include="Grpc.Core, Version=1.0.0.0, Culture=neutral, PublicKeyToken=d754f35622e28bad, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\Grpc.Core.1.22.1\lib\net45\Grpc.Core.dll</HintPath>
</Reference>
<Reference Include="Grpc.Core.Api, Version=2.0.0.0, Culture=neutral, PublicKeyToken=d754f35622e28bad, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\Grpc.Core.Api.2.23.0\lib\net45\Grpc.Core.Api.dll</HintPath>
<Reference Include="Grpc.Core.Api, Version=1.0.0.0, Culture=neutral, PublicKeyToken=d754f35622e28bad, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\Grpc.Core.Api.1.22.1\lib\net45\Grpc.Core.Api.dll</HintPath>
</Reference>
<Reference Include="Microsoft.CodeDom.Providers.DotNetCompilerPlatform, Version=2.0.1.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\Microsoft.CodeDom.Providers.DotNetCompilerPlatform.2.0.1\lib\net45\Microsoft.CodeDom.Providers.DotNetCompilerPlatform.dll</HintPath>
Expand All @@ -105,7 +108,7 @@
<HintPath>..\..\..\packages\Microsoft.Extensions.Primitives.1.1.1\lib\netstandard1.0\Microsoft.Extensions.Primitives.dll</HintPath>
</Reference>
<Reference Include="Newtonsoft.Json, Version=12.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\Newtonsoft.Json.12.0.2\lib\net45\Newtonsoft.Json.dll</HintPath>
<HintPath>..\..\..\packages\Newtonsoft.Json.12.0.3\lib\net45\Newtonsoft.Json.dll</HintPath>
</Reference>
<Reference Include="System.Buffers, Version=4.0.3.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\System.Buffers.4.5.0\lib\netstandard1.1\System.Buffers.dll</HintPath>
Expand All @@ -120,8 +123,8 @@
</Reference>
<Reference Include="System.Net.Http" />
<Reference Include="System.Numerics" />
<Reference Include="System.Runtime.CompilerServices.Unsafe, Version=4.0.4.1, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\System.Runtime.CompilerServices.Unsafe.4.5.2\lib\netstandard1.0\System.Runtime.CompilerServices.Unsafe.dll</HintPath>
<Reference Include="System.Runtime.CompilerServices.Unsafe, Version=4.0.6.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\System.Runtime.CompilerServices.Unsafe.4.7.0\lib\netstandard1.0\System.Runtime.CompilerServices.Unsafe.dll</HintPath>
</Reference>
<Reference Include="System.Runtime.InteropServices.RuntimeInformation, Version=4.0.1.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\System.Runtime.InteropServices.RuntimeInformation.4.3.0\lib\net45\System.Runtime.InteropServices.RuntimeInformation.dll</HintPath>
Expand Down Expand Up @@ -201,8 +204,8 @@
<ErrorText>This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}.</ErrorText>
</PropertyGroup>
<Error Condition="!Exists('..\..\..\packages\Microsoft.CodeDom.Providers.DotNetCompilerPlatform.2.0.1\build\net45\Microsoft.CodeDom.Providers.DotNetCompilerPlatform.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\..\packages\Microsoft.CodeDom.Providers.DotNetCompilerPlatform.2.0.1\build\net45\Microsoft.CodeDom.Providers.DotNetCompilerPlatform.props'))" />
<Error Condition="!Exists('..\..\..\packages\Microsoft.Net.Compilers.3.2.1\build\Microsoft.Net.Compilers.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\..\packages\Microsoft.Net.Compilers.3.2.1\build\Microsoft.Net.Compilers.props'))" />
<Error Condition="!Exists('..\..\..\packages\Grpc.Core.1.22.1\build\net45\Grpc.Core.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\..\..\packages\Grpc.Core.1.22.1\build\net45\Grpc.Core.targets'))" />
<Error Condition="!Exists('..\..\..\packages\Microsoft.Net.Compilers.3.3.1\build\Microsoft.Net.Compilers.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\..\packages\Microsoft.Net.Compilers.3.3.1\build\Microsoft.Net.Compilers.props'))" />
</Target>
<Import Project="..\..\..\packages\Grpc.Core.1.22.1\build\net45\Grpc.Core.targets" Condition="Exists('..\..\..\packages\Grpc.Core.1.22.1\build\net45\Grpc.Core.targets')" />
<!-- To modify your build process, add your task inside one of the targets below and uncomment it.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,24 +1,25 @@
<?xml version="1.0" encoding="utf-8"?>
<packages>
<package id="Google.Ads.GoogleAds" version="2.5.0" targetFramework="net452" />
<package id="Google.Ads.GoogleAds" version="2.6.0" targetFramework="net452" />
<package id="Google.Api.CommonProtos" version="1.7.0" targetFramework="net452" />
<package id="Google.Api.Gax" version="2.9.0" targetFramework="net452" />
<package id="Google.Api.Gax.Grpc" version="2.9.0" targetFramework="net452" />
<package id="Google.Apis" version="1.41.1" targetFramework="net452" />
<package id="Google.Apis.Auth" version="1.41.1" targetFramework="net452" />
<package id="Google.Apis.Core" version="1.41.1" targetFramework="net452" />
<package id="Google.Protobuf" version="3.9.1" targetFramework="net452" />
<package id="Grpc.Auth" version="2.23.0" targetFramework="net452" />
<package id="Google.Api.Gax" version="2.10.0" targetFramework="net452" />
<package id="Google.Api.Gax.Grpc" version="2.10.0" targetFramework="net452" />
<package id="Google.Apis" version="1.42.0" targetFramework="net452" />
<package id="Google.Apis.Auth" version="1.42.0" targetFramework="net452" />
<package id="Google.Apis.Core" version="1.42.0" targetFramework="net452" />
<package id="Google.LongRunning" version="1.1.0" targetFramework="net452" />
<package id="Google.Protobuf" version="3.11.1" targetFramework="net452" />
<package id="Grpc.Auth" version="1.22.1" targetFramework="net452" />
<package id="Grpc.Core" version="1.22.1" targetFramework="net452" />
<package id="Grpc.Core.Api" version="2.23.0" targetFramework="net452" />
<package id="Grpc.Core.Api" version="1.22.1" targetFramework="net452" />
<package id="Microsoft.CodeDom.Providers.DotNetCompilerPlatform" version="2.0.1" targetFramework="net452" />
<package id="Microsoft.Extensions.Configuration" version="1.1.2" targetFramework="net452" />
<package id="Microsoft.Extensions.Configuration.Abstractions" version="1.1.2" targetFramework="net452" />
<package id="Microsoft.Extensions.Primitives" version="1.1.1" targetFramework="net452" />
<package id="Microsoft.Net.Compilers" version="3.2.1" targetFramework="net452" developmentDependency="true" />
<package id="Microsoft.NETCore.Platforms" version="2.2.3" targetFramework="net452" />
<package id="Microsoft.Net.Compilers" version="3.3.1" targetFramework="net452" developmentDependency="true" />
<package id="Microsoft.NETCore.Platforms" version="3.1.0" targetFramework="net452" />
<package id="NETStandard.Library" version="2.0.3" targetFramework="net452" />
<package id="Newtonsoft.Json" version="12.0.2" targetFramework="net452" />
<package id="Newtonsoft.Json" version="12.0.3" targetFramework="net452" />
<package id="System.Buffers" version="4.5.0" targetFramework="net452" />
<package id="System.Collections" version="4.3.0" targetFramework="net452" />
<package id="System.Collections.Concurrent" version="4.3.0" targetFramework="net452" />
Expand All @@ -40,7 +41,7 @@
<package id="System.Reflection.Primitives" version="4.3.0" targetFramework="net452" />
<package id="System.Resources.ResourceManager" version="4.3.0" targetFramework="net452" />
<package id="System.Runtime" version="4.3.1" targetFramework="net452" />
<package id="System.Runtime.CompilerServices.Unsafe" version="4.5.2" targetFramework="net452" />
<package id="System.Runtime.CompilerServices.Unsafe" version="4.7.0" targetFramework="net452" />
<package id="System.Runtime.Extensions" version="4.3.1" targetFramework="net452" />
<package id="System.Runtime.InteropServices" version="4.3.0" targetFramework="net452" />
<package id="System.Runtime.InteropServices.RuntimeInformation" version="4.3.0" targetFramework="net452" />
Expand Down
2 changes: 1 addition & 1 deletion examples/Google.Ads.GoogleAds.Examples.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<None Remove="Migration\**" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="Google.Ads.GoogleAds" Version="2.5.0" />
<PackageReference Include="Google.Ads.GoogleAds" Version="2.6.0" />
</ItemGroup>
<ItemGroup>
<Reference Include="System.Web" />
Expand Down
14 changes: 7 additions & 7 deletions src/Google.Ads.GoogleAds.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,19 @@
<PropertyGroup>
<Title>Google Ads API Dotnet Client Library</Title>
<PackageId>Google.Ads.GoogleAds</PackageId>
<Version>2.5.0</Version>
<Version>2.6.0</Version>
<Description>This library provides you with functionality to access the Google Ads API.</Description>
<PackageReleaseNotes>https://github.com/googleads/google-ads-dotnet/blob/master/ChangeLog</PackageReleaseNotes>
<PackageTags>GoogleAds Google</PackageTags>
<Copyright>Copyright 2018, Google LLC</Copyright>
<Authors>https://github.com/AnashOommen</Authors>
<PackageIconUrl>https://www.gstatic.com/images/icons/material/product/1x/adwords_64dp.png</PackageIconUrl>
<PackageLicenseUrl>http://www.apache.org/licenses/LICENSE-2.0</PackageLicenseUrl>
<PackageProjectUrl>https://github.com/googleads/google-ads-dotnet</PackageProjectUrl>
<Company>Google</Company>
<RepositoryType>git</RepositoryType>
<RepositoryUrl>https://github.com/googleads/google-ads-dotnet</RepositoryUrl>
<PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
<PackageLicenseExpression>Apache-2.0</PackageLicenseExpression>
</PropertyGroup>
<!-- build properties -->
<PropertyGroup>
Expand All @@ -31,8 +31,8 @@
<IncludeSource>true</IncludeSource>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<AssemblyVersion>2.5.0.0</AssemblyVersion>
<FileVersion>2.5.0.0</FileVersion>
<AssemblyVersion>2.6.0.0</AssemblyVersion>
<FileVersion>2.6.0.0</FileVersion>
<LangVersion>latest</LangVersion>
</PropertyGroup>
<ItemGroup>
Expand All @@ -41,9 +41,9 @@
</ItemGroup>
<ItemGroup>
<PackageReference Include="Google.LongRunning" Version="1.1.0" />
<PackageReference Include="Google.Protobuf" Version="3.10.1" />
<PackageReference Include="Google.Protobuf" Version="3.11.1" />
<PackageReference Include="Grpc.Core" Version="1.22.1" />
<PackageReference Include="Google.Api.Gax.Grpc" Version="2.9.0" />
<PackageReference Include="Google.Api.Gax.Grpc" Version="2.10.0" />
<PackageReference Include="Microsoft.Extensions.Configuration" Version="1.1.2" />
</ItemGroup>
<ItemGroup Condition="'$(TargetFramework)'=='netstandard2.0'">
Expand All @@ -70,7 +70,7 @@
<Copy SourceFiles="App.config" DestinationFiles="app.config.transform" />
<Copy SourceFiles="App.config" DestinationFiles="web.config.transform" />
</Target>
<PropertyGroup Condition="'$(TargetFramework)'=='net452'">
<PropertyGroup Condition="'$(TargetFramework)'=='net452'">
<DefineConstants>NET452</DefineConstants>
</PropertyGroup>
<!--
Expand Down