Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Rails 6.1 #180

Closed
kataring opened this issue Apr 23, 2021 · 5 comments
Closed

Support Rails 6.1 #180

kataring opened this issue Apr 23, 2021 · 5 comments

Comments

@kataring
Copy link

kataring commented Apr 23, 2021

Hello guys,

We are using yours google-dfp-api gem in our Rails 6.1(latest vesion) monolith application and actually we are not able to install google-dfp-api gem to due to conflict in dependency libraries.

Is it possible to resolve the dependency of tzinfo ?

$ cat Gemfile
source 'https://rubygems.org'
git_source(:github) { |repo| "https://github.com/#{repo}.git" }

ruby '3.0.1'

# Bundle edge Rails instead: gem 'rails', github: 'rails/rails', branch: 'main'
gem 'rails', '~> 6.1.3', '>= 6.1.3.1'

gem 'google-dfp-api', '1.14.0'
  • activesupport has a dependency on tzinfo (~> 2.0) and google-dfp-api has a dependency on tzinfo (~> 1.0)
$ bundle install
Fetching gem metadata from https://rubygems.org/............
Resolving dependencies...
Bundler could not find compatible versions for gem "tzinfo":
  In snapshot (Gemfile.lock):
    tzinfo (= 2.0.4)

  In Gemfile:
    rails (~> 6.1.3, >= 6.1.3.1) was resolved to 6.1.3.1, which depends on
      sprockets-rails (>= 2.0.0) was resolved to 3.2.2, which depends on
        activesupport (>= 4.0) was resolved to 6.1.3.1, which depends on
          tzinfo (~> 2.0)

    google-dfp-api (= 1.14.0) was resolved to 1.14.0, which depends on
      tzinfo (~> 1.0)

Running `bundle update` will rebuild your snapshot from scratch, using only
the gems in your Gemfile, which may resolve the conflict.

refs. rails/rails@e9425ab

@donovanfm
Copy link
Contributor

Hi, thanks for making us aware of this issue. We should have a new lib release coming up soon with the next API version, so I'll look into changing our dependency requirement with that release.

@skarmakar
Copy link

skarmakar commented May 9, 2021

@donovanfm thanks for the great work! Would the new release support new adwords api?

@mcloonan
Copy link
Member

There has been no new release for the AdWords API since 2019. In fact, we recently announced that that API would be sunset. Instead, you should use the Google Ads API and the new Ruby library for that API if you are currently using the AdWords API.

@donovanfm
Copy link
Contributor

Hey, @skarmakar. Like my colleague said, you'll want to use the new Ruby library for the Google Ads API. In the meantime if you still need this library, I was able to upgrade tzinfo to v2. Grab the latest version (1.15.0) and it should resolve the dependency conflict with activesupport. Thanks for bringing this to our attention!

@kataring
Copy link
Author

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants