Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting Custom Field Value for Creative. Example seems broken #63

Closed
pam- opened this issue Aug 18, 2015 · 5 comments
Closed

Setting Custom Field Value for Creative. Example seems broken #63

pam- opened this issue Aug 18, 2015 · 5 comments

Comments

@pam-
Copy link

pam- commented Aug 18, 2015

Hi, this is issue is regarding this: https://github.com/googleads/google-api-ads-ruby/blob/master/dfp_api/examples/v201505/custom_field_service/set_line_item_custom_field_value.rb

I'm following the example and setting the value of my custom field like so:

    custom_field_value = {
      :custom_field_id => custom_creative_field_id,
      :type => 'CustomFieldValue',
      :value => {:type => 'TextValue', :value => ad.current_design_version.vox_ad_name.to_s}
    }

But I keep getting this error: AdsCommon::Errors::UnexpectedParametersError: [:type, :value]
Is there a change in the keys needed for this instance?

@banderson623
Copy link

👍

@nicholaschen
Copy link
Contributor

huh.

@banderson623
Copy link

The heart of it, is what is the expected data type/format for the :value => attribute?

We've tried a handful of different variations, including the one used in example @pam- mentioned above and we've had no luck.

Is anyone else using custom fields on creatives via the ruby gem?

@nicholaschen
Copy link
Contributor

FWIW Pam was told to write in directly to our team and the issue is that the example isn't setting xsi_type (type was incorrect). The current set of examples has been fixed :)

@banderson623
Copy link

Thanks @nicholaschen ! 🌟 Updated docs for the win! 💫 ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants