Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MainActivity.java #85

Merged
merged 2 commits into from Aug 14, 2017
Merged

Update MainActivity.java #85

merged 2 commits into from Aug 14, 2017

Conversation

vjyanand
Copy link
Contributor

@vjyanand vjyanand commented Aug 4, 2017

Populate logo

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@vjyanand
Copy link
Contributor Author

vjyanand commented Aug 4, 2017

I signed it!

ericleich
ericleich requested changes Aug 7, 2017
View reviewed changes
Copy link
Member

@ericleich ericleich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, great catch. I can't believe this is missing.

Will accept after addressing 2 comments below.

...ncedExample/app/src/main/java/com/google/example/gms/nativeadvancedexample/MainActivity.java Outdated
@@ -147,7 +147,15 @@ public void onVideoEnd() {
adView.getPriceView().setVisibility(View.VISIBLE);
((TextView) adView.getPriceView()).setText(nativeAppInstallAd.getPrice());
}


NativeAd.Image logoImage = nativeAppInstallAd.getIcon();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to iconImage.

...ncedExample/app/src/main/java/com/google/example/gms/nativeadvancedexample/MainActivity.java Outdated
@@ -147,7 +147,15 @@ public void onVideoEnd() {
adView.getPriceView().setVisibility(View.VISIBLE);
((TextView) adView.getPriceView()).setText(nativeAppInstallAd.getPrice());
}


NativeAd.Image logoImage = nativeAppInstallAd.getIcon();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the app icon is a required asset, please move this code up to where the other required assets are set.

@ericleich
Copy link
Member

@vjyanand Do you have time to address the comments? If not, I'll accept and make these changes myself early next week.

@ericleich ericleich merged commit df444f6 into googleads:master Aug 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericleich ericleich ericleich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vjyanand @googlebot @ericleich