Update fyber marketplace 7.4.1 #200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
AsafKoskiWork
commented
Dec 30, 2019
AsafKoskiWork
commented
- updated used FMP version to 7.4.1
- Add a null check for completion callback. Potential crash fix
- Convert app ids collection to set, so the warning message will only appear if we have multiple unique app ids
…ppear if we have multiple unique app ids
spilaka
reviewed
Jan 7, 2020
| @@ -178,21 +178,23 @@ public void initialize(Context context, | |||
| private void waitForInitializationStatusAndReport( | |||
| final @NonNull InitializationCompleteCallback completionCallback) { | |||
There was a problem hiding this comment.
@nonnull is already checking whether it is null or not. I don't think a null check is necessary here.
There was a problem hiding this comment.
Apparently it is necessary, please see #213
There was a problem hiding this comment.
There is another proposed fix for this in pull request #209
| if (configuredAppIds.size() > 1) { | ||
| String message = String.format("Multiple '%s' entries found: %s. " + | ||
| "Using '%s' to initialize the Fyber Marketplace SDK.", | ||
| KEY_APP_ID, appIdForInitialization, appIdForInitialization); | ||
| KEY_APP_ID, configuredAppIds, appIdForInitialization); |
There was a problem hiding this comment.
ConfiguredAppIds returns instances of set object some thing like this '@61bbe9ba'. So, I think it should be appIdForInitialization.
|
Obsolete PR. Closing... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.