Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Tiramasu support with version check for older versions of getApplicationInfo() API #1092

Merged
merged 10 commits into from
May 14, 2024

Conversation

malandr2
Copy link
Collaborator

@malandr2 malandr2 commented May 13, 2024

Description

getApplicationInfo(String, Int) is deprecated in API 33. Added check to use more modern API while still supporting <= 33 API versions.

Related Issues

Issues Resolved

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

Copy link
Collaborator

@LTPhantom LTPhantom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the added changes, tests on FlutterRequestAgentProviderTest run on TIRAMISU and Android S for a total of 8 tests.

@malandr2 malandr2 merged commit 6ec7165 into main May 14, 2024
29 checks passed
@malandr2 malandr2 deleted the jm/application-context-deprecation-fix branch May 14, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants