Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incorrect assertion #39

Merged
merged 1 commit into from Mar 5, 2021
Merged

fix: Incorrect assertion #39

merged 1 commit into from Mar 5, 2021

Conversation

tattn
Copy link
Contributor

@tattn tattn commented Mar 5, 2021

Description

smartBannerLandscape is called on iOS only:

} else if (defaultTargetPlatform == TargetPlatform.iOS &&
orientation == Orientation.landscape) {
return smartBannerLandscape;
}

But the assertion is android. So the following error always occurs when the orientation is landscape on iOS.

======== Exception caught by widgets library =======================================================
The following assertion was thrown while rebuilding dirty elements:
'package:google_mobile_ads/src/ad_containers.dart': Failed assertion: line 214 pos 12: 'defaultTargetPlatform == TargetPlatform.android': is not true.

Related Issues

No issue.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants