Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer mavenCentral #509

Merged
merged 2 commits into from
Feb 9, 2022
Merged

Prefer mavenCentral #509

merged 2 commits into from
Feb 9, 2022

Conversation

jjliu15
Copy link
Collaborator

@jjliu15 jjliu15 commented Feb 8, 2022

Description

Fork of #488, which was automatically closed when the main branch of the repo was renamed.

Adds mavenCentral() to android build.gradle files, for https://blog.gradle.org/jcenter-shutdown.

Related Issues

*Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@jjliu15 jjliu15 requested a review from luo86 February 8, 2022 22:35
Copy link
Collaborator

@luo86 luo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just would like to confirm - do we need to remove jcenter() when JCenter is shutdown?

@jjliu15
Copy link
Collaborator Author

jjliu15 commented Feb 9, 2022

I removed jcenter() altogether, since according to https://blog.gradle.org/jcenter-shutdown support will be removed in future versions of gradle.

@jjliu15 jjliu15 merged commit 5bd973c into googleads:main Feb 9, 2022
@jjliu15 jjliu15 deleted the mavenCentral branch November 14, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants