Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visibility detector workaround for android impression issue #610

Merged
merged 5 commits into from Jul 27, 2022

Conversation

jjliu15
Copy link
Collaborator

@jjliu15 jjliu15 commented Jul 22, 2022

Description

Updates AdWidget to wait until the widget becomes visible once before creating the PlatformViewLink.
This is meant to be a temporary workaround for #580, where the android impression is being fired before the ad widget comes into view.

Related Issues

#580

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@jjliu15 jjliu15 merged commit ee32dfd into googleads:main Jul 27, 2022
@jjliu15 jjliu15 deleted the visibility_detector_workaround branch July 27, 2022 16:30
@jjliu15 jjliu15 mentioned this pull request Jul 27, 2022
10 tasks
jjliu15 added a commit that referenced this pull request Jan 31, 2023
…karound (#762)

* Adds a flag to AdWidget that lets you opt out of visibility detector workaround added in #610.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants