Support simulation for ad metrics #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warrengm
changed the title
jburger424
requested changes
Jun 7, 2019
jburger424
approved these changes
Jun 17, 2019
warrengm
added
scoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly fixes #63
This PR introduces computed artifacts for the main ad metrics. Each computed artifacts supports provided metrics (as before) and simulated metrics (new behavior). Most of the simulation happens in
ad-lantern-metric.js, a super class for ad-related lantern (i.e. simulated) metrics.The tag load time and ad request time audits mostly share the same implementation, but the ad paint time is fairly distinct.
Other metrics will be migrated in follow-up PRs