Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Third param of setContentWithAdTag not working for 'true' case #524

Closed
shawnbuso opened this issue Feb 20, 2018 · 0 comments
Closed

Third param of setContentWithAdTag not working for 'true' case #524

shawnbuso opened this issue Feb 20, 2018 · 0 comments
Assignees
@ypavlotsky
Labels
bug P2

Comments

@shawnbuso
Copy link
Contributor

If you set content and try to autoplay, it doesn't autoplay. This has been broken since refactor and hasn't been reported yet, so remove if there's a cleaner workflow post-refactor.
@shawnbuso shawnbuso self-assigned this Feb 20, 2018
@shawnbuso shawnbuso assigned ypavlotsky and unassigned shawnbuso Jul 26, 2018
gschoppe added a commit that referenced this issue Jun 26, 2019
@gschoppe
Merge pull request #658 from shawnbuso/noplayonload
0067e42 
refactor: Remove playOnLoad from setContentWith(AdTag|AdsResponse|adsRequest). This stopped working with the refactor, and due to how the player and contrib-ads handle autoplay, is no longer supported. Fixes #524.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ypavlotsky ypavlotsky

Labels
bug P2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ypavlotsky @shawnbuso