contentComplete not reset in player wrapper #639
Assignees
Comments
Cosrnos
changed the title
contentComplete not reset in player wrapper
Cosrnos
added a commit
to Cosrnos/videojs-ima
that referenced
this issue
Jun 6, 2018
Fixes a bug that would prevent the nopostroll event from being triggered, causing a delay before contrib-ads would fire the ended event on the player Fixes googleads#639
shawnbuso
pushed a commit
that referenced
this issue
Jun 7, 2018
Fixes a bug that would prevent the nopostroll event from being triggered, causing a delay before contrib-ads would fire the ended event on the player Fixes #639
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We're doing some work with autoplaying related content once our video has ended, and we've run into a bug that pops up when the second video completes. We're listening to the
endedevent to change the content of the player & request an ad break by using thesetContentWithAdTagmethod.I would expect the SDK to call the onCompleted event internally to signal to
contrib-adsthat no post roll will run, but sincecontentCompleteisn't reset, theonNoPostrollmethod isn't calledI'd be more than happy to PR a fix for this assuming there's no unintended side effects of setting
contentComplete = falseon reset calls. We'd love to get a fix for this ASAP so we don't have to wait for a timeout between videosThe text was updated successfully, but these errors were encountered: