Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submitting AdsRequest Object #653

Closed
dilburt opened this issue Jun 13, 2018 · 2 comments
Closed

Submitting AdsRequest Object #653

dilburt opened this issue Jun 13, 2018 · 2 comments
Assignees

Comments

@dilburt
Copy link

dilburt commented Jun 13, 2018

Hi,

I understand that the latest versions of videojs-ima don't require a call to ima.requestAds and that doing so will cause problems. However, I cannot find anything in the API docs or in your sample code that shows how to submit the AdsRequest object. There are 2 methods associated with AdsRequest - setAdWillAutoPlay and setAdWillPlayMuted along with a number of option fields which includes the ad sizes, keywords, duration and several others. Since these were previously passed as the first parameter to requestAds which you are calling internally now, how do we include the AdsRequest object?

Thanks,

D

@shawnbuso shawnbuso self-assigned this Jun 13, 2018
@shawnbuso
Copy link
Contributor

Can you clarify what you mean by "these were previously passed as the first parameter to requestAds"? The requestAds method, as far as I can tell, has never taken any parameters - it was just a call to tell the plugin to send the ads request it had created to the ad server.

I do see that there are properties of the AdsRequest object that are missing from IMA settings, but I don't think we ever had a way to provide these to the plugin. I can take this as an FR to allow you to pass a JSON object in the settings that contains your AdsRequest properties.

shawnbuso added a commit that referenced this issue Jun 13, 2018
#656)

* feat: Allow for an adsRequest object to be passed to the plugin. This allows us to support additional adRequest properties. Fixes #653.

* Updated to accept adsRequest everywhere we accept adTagUrl or adResponse.

* Fix missing null check.

* Fix typo

* Added setContentWithAdsRequest to ima-plugin.

* Fix bad copypasta.

* Fix lint error.
@dilburt
Copy link
Author

dilburt commented Jun 14, 2018

Thanks, that's perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants