Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ima-countdown-div is never displayed #853

Closed
cdatehortuab opened this issue Oct 28, 2019 · 1 comment · Fixed by #854
Closed

ima-countdown-div is never displayed #853

cdatehortuab opened this issue Oct 28, 2019 · 1 comment · Fixed by #854

Comments

@cdatehortuab
Copy link
Contributor

cdatehortuab commented Oct 28, 2019

Hello, there is a bug introduced in PR #836.

If you check line 149 in ad-ui.js there is an if clause:

if (!this.controller.getIsMobile) {

But this.controller.getIsMobile is a function so it always has a truthy value so that clause is never true and ima-countdown-div never gets the appropiate attributes and it is always hidden, not only for mobile.

In any case, I think the solution for the bug that the PR #836 tries to solve (#453) is different, because it happens when showControlsForJsAds is true but a VAST file without VPAID is retrieved.

cdatehortuab added a commit to cdatehortuab/videojs-ima that referenced this issue Oct 28, 2019
cdatehortuab added a commit to cdatehortuab/videojs-ima that referenced this issue Oct 28, 2019
@Kiro705
Copy link
Member

Kiro705 commented Oct 28, 2019

Hi @cdatehortuab ,

Thank you for catching this and making the appropriate PR.

I will merge in the change now.

@Kiro705 Kiro705 closed this as completed Oct 28, 2019
Kiro705 added a commit that referenced this issue Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants