Added type to content source #433
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
Added a small comment. Thanks for the PR! |
|
Hi, After the post-roll complete: the player crash with a not supported format error: because it needs to know the correct source type. |
|
Makes sense - once you resolve the comment I left and the CLA we should be good to go :) |
|
Hi, |
|
CLAs look good, thanks! |
src/videojs.ima.js
Outdated
| @@ -1333,6 +1337,7 @@ | |||
| * post-roll on iOS. | |||
| */ | |||
| this.contentSource = ''; | |||
| this.contentSourceType = ''; | |||
There was a problem hiding this comment.
Can you add a comment for this like we have for the other variables indicating what it is?
|
Oh whoops, it looks like I started a review but never submitted it - you should see it now. |
|
Thanks for the fix! |
* Initial commit for gh-pages * Added a link to the iPhone sample on the gh-pages index. * Merging latest updates from master * Updating videojs-contrib-ads to 3.1.2 * Added autoplay example to samples index. * Tech agnostic contentPlayer Changed contentPlayer selector to be tech agnostic (will get object irrespective of it being an html5_api or Flash_api instance). Adds compatibility for IE 11 browsers using Flash and HLS. * Revert "Merge remote-tracking branch 'origin/gh-pages'" This reverts commit d3b9e49, reversing changes made to 1232b41. * Revert "Merge pull request #433 from valse/master" This reverts commit 1232b41, reversing changes made to dcb063f. # Conflicts: # src/videojs.ima.js * Revert "Revert "Merge pull request #433 from valse/master"" This reverts commit 0c6651a.
Resolved an issue with IMA plugin and HLS plugin on post-roll completed ads: without the source type the player hangs with a format not supported error.