-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Update autoplay sample and how we report adsWillAutoplay an… #562
Merged
Commits on Mar 14, 2018
-
refactor: Update autoplay sample and how we report adsWillAutoplay an…
…d adsWillPlayMuted. Also deprecates the options ad(s)WillPlayMuted and ad(s)WillAutoPlay. Fixes #341.
Configuration menu - View commit details
-
Copy full SHA for a1e1315 - Browse repository at this point
Copy the full SHA a1e1315View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e104fd - Browse repository at this point
Copy the full SHA 3e104fdView commit details -
Use getPlayerOptions() instead of vjsPlayer.options_ in controller ge…
…tAdsWillAutoplay.
Configuration menu - View commit details
-
Copy full SHA for 9e3efcd - Browse repository at this point
Copy the full SHA 9e3efcdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f06857 - Browse repository at this point
Copy the full SHA 7f06857View commit details
Commits on Mar 15, 2018
-
Move can-autoplay from devDependencies to dependencies. I feel like i…
…f it's required to run the samples then it should probably be in dependencies.
Configuration menu - View commit details
-
Copy full SHA for 9e1eca4 - Browse repository at this point
Copy the full SHA 9e1eca4View commit details -
Configuration menu - View commit details
-
Copy full SHA for c4ffd64 - Browse repository at this point
Copy the full SHA c4ffd64View commit details
Commits on Mar 23, 2018
-
Configuration menu - View commit details
-
Copy full SHA for cbcc314 - Browse repository at this point
Copy the full SHA cbcc314View commit details
Commits on Mar 27, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 66aca23 - Browse repository at this point
Copy the full SHA 66aca23View commit details
Commits on Mar 28, 2018
-
Configuration menu - View commit details
-
Copy full SHA for af9bc2a - Browse repository at this point
Copy the full SHA af9bc2aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.