Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing rules for AIP-162 #721

Closed
44 of 45 tasks
apasel422 opened this issue Jan 6, 2021 · 2 comments · Fixed by #813
Closed
44 of 45 tasks

Missing rules for AIP-162 #721

apasel422 opened this issue Jan 6, 2021 · 2 comments · Fixed by #813
Assignees
@apasel422
Labels
🚨 triage me

Comments

@apasel422
Copy link
Contributor

apasel422 commented Jan 6, 2021 •
edited
Loading

https://google.aip.dev/162

Tag Revision

  • HTTP body
  • HTTP method
  • HTTP URI suffix
  • Request message name
  • Request name field
  • Request name field behavior
  • Request name field resource reference
  • Request tag field
  • Request tag field behavior
  • Response message name

List Revisions

  • HTTP body
  • HTTP method
  • HTTP URI suffix
  • Request message name
  • Request name field
  • Request name field behavior
  • Request name field resource reference
  • Request should not have an order_by field
  • Response message name

Commit Revision

  • HTTP body
  • HTTP method
  • HTTP URI suffix
  • Request message name
  • Request name field
  • Request name field behavior
  • Request name field resource reference
  • Response message name

Rollback

  • HTTP body
  • HTTP method
  • HTTP URI suffix
  • Request message name
  • Request name field
  • Request name field behavior
  • Request name field resource reference
  • Request revision_id field
  • Request revision_id field behavior
  • Response message name

Delete Revision

  • HTTP body
  • HTTP method
  • HTTP URI suffix
  • Request message name
  • Request name field
  • Request name field behavior
  • Request name field resource reference
  • Response message name
@apasel422 apasel422 self-assigned this Jan 6, 2021
This was referenced Jan 6, 2021
Merged
Closed
@apasel422 apasel422 removed their assignment Jan 7, 2021
@apasel422 apasel422 mentioned this issue Jan 8, 2021
Merged
This was referenced Jan 20, 2021
Merged
Merged
@apasel422 apasel422 self-assigned this Jan 21, 2021
This was referenced Jan 21, 2021
Merged
Merged
This was referenced Jan 28, 2021
Merged
Merged
Merged
Merged
Merged
This was referenced Feb 5, 2021
Merged
Merged
Merged
Merged
Merged
This was referenced Feb 12, 2021
Merged
Merged
@apasel422 apasel422 removed their assignment Feb 24, 2021
This was referenced Mar 4, 2021
Merged
Merged
Merged
Merged
Merged
This was referenced Mar 10, 2021
Merged
Merged
Merged
Merged
Merged
@apasel422 apasel422 self-assigned this Mar 12, 2021
@apasel422
Copy link
Contributor Author

Implementing the Delete Revision response-message-name check is blocked by resolving aip-dev/google.aip.dev#715:

What should the return type be for a soft-delete Delete Revision method? Still google.protobuf.Empty?

@apasel422 apasel422 mentioned this issue Mar 30, 2021
Merged
@lukesneeringer
Copy link
Contributor

What should the return type be for a soft-delete Delete Revision method? Still google.protobuf.Empty?

Probably the resource.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apasel422 apasel422

Labels
🚨 triage me
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add rule for AIP-162 Delete Revision response message name
3 participants
@lukesneeringer @apasel422 @yoshi-automation