This repository has been archived by the owner on Mar 1, 2022. It is now read-only.
Make packman always use local protos for gRPC gen #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import_proto_path, packman_flags=[]): | ||
| arg_list = [language, api_name, '-o', output_dir] | ||
|
|
||
| # TODO: Thos is a workaround for a packman issue: |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -21,7 +21,7 @@ commands = flake8 --max-complexity=8 pipeline --exclude='test/output' test | |||
| [testenv:pylint-errors] | |||
| deps = pylint | |||
| -r{toxinidir}/requirements.txt | |||
| commands = pylint -f colorized -E pipeline --ignore test/output test | |||
| commands = pylint -f colorized -E pipeline | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Current coverage is 69.40% (diff: 93.75%)@@ master #45 diff @@
==========================================
Files 28 28
Lines 881 889 +8
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 609 617 +8
Misses 272 272
Partials 0 0
|
| imps = map(remove_google_dirs, import_proto_path) | ||
| srcs = map(remove_google_dirs, src_proto_path) | ||
|
|
||
| arg_list += [arg for src in srcs for arg in ('-r', src)] |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
FYI -- I will add PRs to packman and googleapis that correspond to this one soon. |
| @@ -23,7 +23,6 @@ | |||
| class PackmanTaskBase(task_base.TaskBase): | |||
| def run_packman(self, language, api_name, *additional_args): | |||
| # Fix the api_name convention (ex. logging-v2) for packman. | |||
| api_name = api_name.replace('-', '/') | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@jmuk PTAL |
Previously, it always downloaded the public googleapis repo. That does not work if an API is not on googleapis.
Pre-push hook installed. Change-Id: I0dac8fbcee79741dfa988ab9fe32de260581ed90
This allow it to be shared with the GAPIC task. Also fix a camelCase function name. Pre-push hook installed. Change-Id: I1dc1a7c64ff5c2ef1e7af8a2366a04cc10ba32df
Pre-push hook installed. Change-Id: I01518afbf9ec737952033df371c8cc2cd8812c75
Packman loses the 'grpc-' prefix when isGoogleApi is not set; see https://github.com/googleapis/packman/blob/59d486dcaf5242844bd2935fccffd1a465975cb9/bin/gen-api-package#L255 Also fix a mutable default parameter. Pre-push hook installed. Change-Id: Ic83b6eff221b21cbe063ebcaa09dda7e0cea6fb7
Pre-push hook installed. Change-Id: I635e3570ede2ddf1acb8bd654898d09adf3d431a
Packman requires absolute paths -- relative paths do not work. See googleapis/packman#1
|
LGTM. Sorry I missed this. |
bjwatson
pushed a commit
to bjwatson/artman
that referenced
this pull request
Aug 18, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it always downloaded the public googleapis repo. That does
not work if an API is not on googleapis.