This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
build!: update library to use Node 12 #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: This pull request is touching the following templated files:
|
product-auto-label
bot
added
size: m
Codecov Report
@@ Coverage Diff @@
## main #1084 +/- ##
==========================================
- Coverage 66.11% 65.77% -0.35%
==========================================
Files 21 21
Lines 1750 1750
Branches 352 352
==========================================
- Hits 1157 1151 -6
- Misses 510 512 +2
- Partials 83 87 +4
Continue to review full report at Codecov.
|
mctavish
approved these changes
May 17, 2022
| @@ -388,7 +388,7 @@ export class Debuglet extends EventEmitter { | |||
| findResults = await Debuglet.findFiles(this.config, gaeId); | |||
| findResults.errors.forEach(this.logger.warn); | |||
| } catch (err) { | |||
| this.logger.error('Error scanning the filesystem.', err); | |||
| this.logger.error('Error scanning the filesystem.', err as Error); | |||
There was a problem hiding this comment.
The linter thanks you, as do I.
|
Looks like this got stuck waiting for a test status for node 10. Do you know how to reset its expectations? That test result isn't coming in. |
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jun 30, 2022
🤖 I have created a release *beep* *boop* --- ## [7.0.0](v6.0.1...v7.0.0) (2022-06-25) ### ⚠ BREAKING CHANGES * upgrade to stable (#1088) * update library to use Node 12 (#1084) ### Features * upgrade to stable ([#1088](#1088)) ([792ef81](792ef81)) ### Bug Fixes * **deps:** update dependency @google-cloud/common to v4 ([#1090](#1090)) ([f4f6ad4](f4f6ad4)) * **deps:** update dependency firebase-admin to v10 ([#1080](#1080)) ([957ea3c](957ea3c)) * **deps:** update dependency gcp-metadata to v5 ([#1068](#1068)) ([20ff5c5](20ff5c5)) ### Build System * update library to use Node 12 ([#1084](#1084)) ([3434ddd](3434ddd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate library to Node 12