Fill in unimplemented tests #199

matthewloring · 2016-12-17T06:44:07Z

No description provided.

test/standalone/test-debuglet.js

+    debuglet = new Debuglet(fakeDebug, config, logger);
+
+    debuglet.once('initError', function(err) {
+      assert(err);


test/standalone/test-debuglet.js

@@ -195,11 +205,88 @@ describe(__filename, function(){
    debuglet.start();
  });

-  it('should de-activate when the server responds with isDisabled');
+  it('should de-activate when the server responds with isDisabled', function(done) {


test/standalone/test-debuglet.js

+    debuglet.start();
+  });
+
+  it('should re-register when registration expires', function(done) {


ofrobots

LGTM w/ nits.

test/standalone/test-debuglet.js

+      });
+
+    debuglet.once('registered', function(id) {
+      assert(id === DEBUGGEE_ID);


test/standalone/test-debuglet.js

+    debuglet.once('registered', function(id) {
+      assert(id === DEBUGGEE_ID);
+      setImmediate(function() {
+        assert(debuglet.fetcherActive_);


test/standalone/test-debuglet.js

+    });
+
+    setTimeout(function() {
+      assert(!debuglet.fetcherActive_);


googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 17, 2016

matthewloring requested review from ofrobots, kjin, cristiancavalli and DominicKramer December 17, 2016 06:44

ofrobots suggested changes Dec 19, 2016

View reviewed changes

ofrobots approved these changes Dec 19, 2016

View reviewed changes

Fill in unimplemented tests

6cbd791

matthewloring merged commit 4dc2aa0 into googleapis:master Dec 19, 2016

matthewloring deleted the tests branch December 19, 2016 19:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fill in unimplemented tests #199

Fill in unimplemented tests #199

matthewloring commented Dec 17, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

ofrobots left a comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

Fill in unimplemented tests #199

Fill in unimplemented tests #199

Conversation

matthewloring commented Dec 17, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

ofrobots left a comment

Choose a reason for hiding this comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.