This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
Indicate breakpoint expiration using the refers_to field #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
ofrobots
reviewed
Jun 6, 2017
test/test-debuglet.js
Outdated
| return status.description.format === | ||
| 'The snapshot has expired' && | ||
| status.refersTo === | ||
| 'BREAKPOINT_AGE'; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ofrobots
suggested changes
Jun 6, 2017
src/agent/debuglet.js
Outdated
| @@ -650,7 +650,7 @@ Debuglet.prototype.scheduleBreakpointExpiry_ = function(breakpoint) { | |||
| format: 'The snapshot has expired' | |||
| }, | |||
| isError: true, | |||
| refersTo: 'unspecified' | |||
| refersTo: 'BREAKPOINT_AGE' | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ofrobots
approved these changes
Jun 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.