Avoid repeated indexOf checks in tests #273

matthewloring · 2017-06-06T22:32:45Z

No description provided.

ofrobots

Ah, so much more readable. LGTM with minor nit.

test/test-v8debugapi.js

-        assert(bp.status.description.format.indexOf(
-          'foo.js:500') !== -1);
+        assert(bp.status.description.format.match(
+          api.messages.INVALID_LINE_NUMBER + '.*foo.js:500'));


matthewloring requested review from ofrobots and DominicKramer June 6, 2017 22:32

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 6, 2017

jmdobry added the in progress label Jun 6, 2017

ofrobots approved these changes Jun 6, 2017

View reviewed changes

test/test-v8debugapi.js Outdated

assert(bp.status.description.format.indexOf(

'foo.js:500') !== -1);

assert(bp.status.description.format.match(

api.messages.INVALID_LINE_NUMBER + '.*foo.js:500'));

This comment was marked as spam.

Sign in to view

Avoid repeated indexOf checks in tests

80935b1

matthewloring merged commit adcf3ae into googleapis:master Jun 7, 2017

matthewloring deleted the regex branch June 7, 2017 00:03

jmdobry removed the in progress label Jun 7, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avoid repeated indexOf checks in tests #273

Avoid repeated indexOf checks in tests #273

matthewloring commented Jun 6, 2017

ofrobots left a comment

This comment was marked as spam.

Avoid repeated indexOf checks in tests #273

Avoid repeated indexOf checks in tests #273

Conversation

matthewloring commented Jun 6, 2017

ofrobots left a comment

Choose a reason for hiding this comment

This comment was marked as spam.