Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

Use Typescript class syntax #285

Merged

Conversation

DominicKramer
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 27, 2017
Copy link
Contributor

@ofrobots ofrobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The comment about the require('*.js') should be addressed in a follow-on.

@@ -30,7 +30,7 @@ var common = require('@google-cloud/common');
var v8debugapi = require('./v8debugapi.js');
var Debuggee = require('../debuggee.js');
var DebugletApi = require('../controller.js');
var defaultConfig = require('./config.js');
var defaultConfig = require('./config.js').default;

This comment was marked as spam.

This comment was marked as spam.

@DominicKramer DominicKramer merged commit ec19973 into googleapis:master Jun 27, 2017
@DominicKramer DominicKramer deleted the to-ts-prs/2-use-ts-class-syntax branch July 6, 2017 20:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants